Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing transformer crash on Null Arrays #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing transformer crash on Null Arrays #65

wants to merge 1 commit into from

Conversation

stribioli
Copy link

Redis return Null Arrays in specific situations (e.g. BLPOP timeouts or EXEC if aborting).

Before this commit, _MultiBulkConsumercrashed with a RangeError, while trying to create a List with -1 lenght.

Redis doc states:

A client library API should return a null object and not an empty Array when Redis replies with a Null Array

This simple fix does not comply with this suggestion. A larger rework would be required to return a Null object.

@stribioli
Fixing transformer crash on Null Arrays
70db569 
Redis return Null Arrays in specific situations (e.g. BLPOP
timeouts or EXEC if aborting).

Before this commit, _MultiBulkConsumer crashed with a
RangeError, while trying to create a List with -1 lenght.

Redis doc states: "A client library API should return a null
object and not an empty Array when Redis replies with a
Null Array".
This simple fix does not comply with this suggestion. A larger
rework would be required to return a Null object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stribioli